Fix MCP test independence #5046
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:L
Member
Author
cte
reviewed
Jun 23, 2025
| } | ||
| } | ||
| api.on("taskCompleted", taskCompletedHandler) | ||
| await sleep(2000) // Wait for Roo Code to fully initialize |
Collaborator
There was a problem hiding this comment.
Could we hook into our event emitter to determine if we're initialized instead of sleeping?
Member
Author
There was a problem hiding this comment.
It seems like taskStarted will not wait for MCP servers to be initialized causing the model to not see them.
Do you know of any event I can use to wait for the MCP servers to initialize?
interface RooCodeAPIEvents {
message: [data: {
taskId: string;
action: "created" | "updated";
message: ClineMessage;
}];
taskCreated: [taskId: string];
taskStarted: [taskId: string];
taskModeSwitched: [taskId: string, mode: string];
taskPaused: [taskId: string];
taskUnpaused: [taskId: string];
taskAskResponded: [taskId: string];
taskAborted: [taskId: string];
taskSpawned: [parentTaskId: string, childTaskId: string];
taskCompleted: [taskId: string, tokenUsage: TokenUsage, toolUsage: ToolUsage, isSubtask: IsSubtask];
taskTokenUsageUpdated: [taskId: string, tokenUsage: TokenUsage];
taskToolFailed: [taskId: string, toolName: ToolName, error: string];
}
daniel-lxs
moved this from PR [Needs Review]
to PR [Changes Requested]
in Roo Code Roadmap
…on MCP server initialization
|
We have finished reviewing your PR. We have found no vulnerabilities. Reply to this PR with |
github-project-automation
bot
moved this from PR [Changes Requested]
to Done
in Roo Code Roadmap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensures each MCP test sets up its own configuration independently by adding alwaysAllow permissions setup to all tests. This prevents test failures when tests run in different orders.
Important
Ensures MCP test independence by setting up individual configurations and introduces
mcpServersInitializedevent for server initialization handling.use-mcp-tool.test.tssets up its own configuration independently by modifying themcpConfigto includealwaysAllowpermissions.use-mcp-tool.test.ts.mcpServersInitializedevent toRooCodeAPIEventsinapi.tsandipc.ts.mcpServersInitializedinMcpHubafter server connections are updated.ClineProviderEventsinClineProvider.tsto includemcpServersInitialized.APIinapi.tsto listen formcpServersInitializedand emit it.This description was created by
for e52478f. You can customize this summary. It will automatically update as commits are pushed.